From d1958f289c72441a148f0005c5ac76d58a0f8357 Mon Sep 17 00:00:00 2001 From: Aadhavan Srinivasan Date: Sun, 9 Feb 2025 16:08:16 -0500 Subject: [PATCH] Commented out tests that would only pass with Longest() --- regex/re_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/regex/re_test.go b/regex/re_test.go index de6aaba..8b9fc8d 100644 --- a/regex/re_test.go +++ b/regex/re_test.go @@ -25,7 +25,9 @@ var reTests = []struct { {"a*b", nil, "qwqw", []Group{}}, {"(abc)*", nil, "abcabcabc", []Group{{0, 9}, {9, 9}}}, {"((abc)|(def))*", nil, "abcdef", []Group{{0, 6}, {6, 6}}}, - {"(abc)*|(def)*", nil, "abcdef", []Group{{0, 3}, {3, 6}, {6, 6}}}, + // This match will only happen with Longest() + // {"(abc)*|(def)*", nil, "abcdef", []Group{{0, 3}, {3, 6}, {6, 6}}}, + {"(abc)*|(def)*", nil, "abcdef", []Group{{0, 3}, {3, 3}, {4, 4}, {5, 5}, {6, 6}}}, {"b*a*a", nil, "bba", []Group{{0, 3}}}, {"(ab)+", nil, "abcabddd", []Group{{0, 2}, {3, 5}}}, {"a(b(c|d)*)*", nil, "abccbd", []Group{{0, 6}}}, @@ -537,7 +539,9 @@ var groupTests = []struct { {"(a+)|(a)", nil, "aaaa", []Match{[]Group{{0, 4}, {0, 4}, {-1, -1}}}}, {"(a+)(aa)", nil, "aaaa", []Match{[]Group{{0, 4}, {0, 2}, {2, 4}}}}, {"(aaaa)|(aaaa)", nil, "aaaa", []Match{[]Group{{0, 4}, {0, 4}, {-1, -1}}}}, - {"(aaa)|(aaaa)", nil, "aaaa", []Match{[]Group{{0, 4}, {-1, -1}, {0, 4}}}}, + // This match will only happen with Longest() + // {"(aaa)|(aaaa)", nil, "aaaa", []Match{[]Group{{0, 4}, {-1, -1}, {0, 4}}}}, + {"(aaa)|(aaaa)", nil, "aaaa", []Match{[]Group{{0, 3}, {0, 3}, {-1, -1}}}}, {"(aaaa)|(aaa)", nil, "aaaa", []Match{[]Group{{0, 4}, {0, 4}, {-1, -1}}}}, {"(a)|(aa)", nil, "aa", []Match{[]Group{{0, 1}, {0, 1}}, []Group{{1, 2}, {1, 2}}}}, {"(a?)a?", nil, "b", []Match{[]Group{{0, 0}, {0, 0}}, []Group{{1, 1}, {1, 1}}}},