From 61bced606e8a7d1fe99b26188734742c0826f4cc Mon Sep 17 00:00:00 2001 From: Aadhavan Srinivasan Date: Mon, 16 Dec 2024 22:32:22 -0500 Subject: [PATCH] Added comments - certain members of State depend on the current match, should be reset --- nfa.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nfa.go b/nfa.go index 0acae90..37d67d3 100644 --- a/nfa.go +++ b/nfa.go @@ -28,7 +28,6 @@ type State struct { transitions map[int][]*State // Transitions to different states (maps a character (int representation) to a _list of states. This is useful if one character can lead multiple states eg. ab|aa) isKleene bool // Identifies whether current node is a 0-state representing Kleene star assert assertType // Type of assertion of current node - NONE means that the node doesn't assert anything - zeroMatchFound bool // Whether or not the state has been used for a zero-length match - only relevant for zero states allChars bool // Whether or not the state represents all characters (eg. a 'dot' metacharacter). A 'dot' node doesn't store any contents directly, as it would take up too much space except []rune // Only valid if allChars is true - match all characters _except_ the ones in this block. Useful for inverting character classes. lookaroundRegex string // Only for lookaround states - Contents of the regex that the lookaround state holds @@ -37,7 +36,9 @@ type State struct { groupBegin bool // Whether or not the node starts a capturing group groupEnd bool // Whether or not the node ends a capturing group groupNum int // Which capturing group the node starts / ends - threadGroups []Group // Assuming that a state is part of a 'thread' in the matching process, this array stores the indices of capturing groups in the current thread. As matches are found for this state, its groups will be copied over. + // The following properties depend on the current match - I should think about resetting them for every match. + zeroMatchFound bool // Whether or not the state has been used for a zero-length match - only relevant for zero states + threadGroups []Group // Assuming that a state is part of a 'thread' in the matching process, this array stores the indices of capturing groups in the current thread. As matches are found for this state, its groups will be copied over. } // Clones the NFA starting from the given state.